Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mod Interaction][Bug] #2825

Closed
ReikaKalseki opened this issue Jun 20, 2015 · 13 comments
Closed

[Mod Interaction][Bug] #2825

ReikaKalseki opened this issue Jun 20, 2015 · 13 comments

Comments

@ReikaKalseki
Copy link
Contributor

For some reason, the BC quarry seems to mostly ignore ReactorCraft fluorite ores. I have no idea why, seeing as the most unusual thing about this ore is its luminosity.

Its code for reference:
https://github.com/ReikaKalseki/ReactorCraft/blob/master/Blocks/BlockFluoriteOre.java
https://github.com/ReikaKalseki/ReactorCraft/blob/master/Blocks/BlockFluorite.java

My best guess is its transparency to light that is making this happen.

@BigXplosion
Copy link
Contributor

I heard that making sure that your block is opaque (or any other indicator that would make it a full block) is a fix for this.

@asiekierka
Copy link
Member

It is strange, and it's not the first report. This is worth checking.

@ReikaKalseki
Copy link
Contributor Author

I heard that making sure that your block is opaque (or any other indicator that would make it a full block) is a fix for this.

As I said, while isOpaqueCube() returns true, it is not opaque to light as per getLightOpacity(), nor can it be, because that will cause render glitches.

@ReikaKalseki
Copy link
Contributor Author

So...any updates?

@asiekierka
Copy link
Member

I usually leave the stranger issues for when I'm in a good mood. Maybe today.

@ReikaKalseki
Copy link
Contributor Author

Works for me. :P

There is no rush, as nothing really breaks, but it does generate about one bug report per week.

@asiekierka
Copy link
Member

@ReikaKalseki - tried putting deobf ReactorCraft into workspace, crashed on signatures. Woo.

@ReikaKalseki
Copy link
Contributor Author

Try adding it as source. Also how did you get a deobf version?

@asiekierka
Copy link
Member

I used "illegal" methods, that is Bearded Octo Nemesis, but you sign your stuff so it failed.

@ReikaKalseki
Copy link
Contributor Author

I have no problem with BON for this purpose, but yes, the jar signing will catch that. Do you need me to make a source jar?

@asiekierka
Copy link
Member

asiekierka commented Jul 12, 2015 via email

@ReikaKalseki
Copy link
Contributor Author

Oh, good. What was causing it?

@psxlover
Copy link
Contributor

915d900
My guess is worldObj.getHeightValue() didn't consider non-opaque blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants