Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.12.2] [PIPES] getBlockFaceShape() always returns BlockFaceShape.SOLID #3994

Closed
Managarmr719 opened this issue Jan 23, 2018 · 0 comments
Closed

[1.12.2] [PIPES] getBlockFaceShape() always returns BlockFaceShape.SOLID #3994

Managarmr719 opened this issue Jan 23, 2018 · 0 comments
Labels
type: bug Something isn't behaving as expected, from a developer perspective. (Except crashes are always bugs) version: 1.12.2

Comments

@Managarmr719
Copy link
Contributor

Managarmr719 commented Jan 23, 2018 •
edited

I found this while testing MinecraftForge/MinecraftForge#4680. The PR fixes an inconsistency between vanilla glass and modded glass. This is done by checking if the block face that's against the water block is solid, however Buildcraft pipes always return BlockFaceShape.SOLID even without a facade.

Also tested with the version here on github and the issue changed to some returning BlockFaceShape.UNDEFINED when they shouldn't (i.e. Glass facade), seems to have changed because of the getBlockFaceShape() override on 8aa06a8.

BuildCraft version: 7.99.14
Forge version:
Link to crash report or log:
Singleplayer or multiplayer: Both
Additional information:
@Managarmr719 Managarmr719 mentioned this issue Jan 23, 2018
Merged
@AEnterprise AEnterprise added type: bug Something isn't behaving as expected, from a developer perspective. (Except crashes are always bugs) version: 1.12.2 labels Jan 24, 2018
@AEnterprise AEnterprise reopened this Jan 25, 2018
@AEnterprise AEnterprise added the status: fixed/implemented in dev We've fixed this internally, however the fix hasn't been released publicly yet. label Jan 25, 2018
@afdw afdw removed the status: fixed/implemented in dev We've fixed this internally, however the fix hasn't been released publicly yet. label Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't behaving as expected, from a developer perspective. (Except crashes are always bugs) version: 1.12.2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AEnterprise @afdw @Managarmr719