Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique identity = Coinbase address #38

Closed
thanhson1085 opened this issue Sep 30, 2018 · 7 comments · Fixed by #41
Closed

Unique identity = Coinbase address #38

thanhson1085 opened this issue Sep 30, 2018 · 7 comments · Fixed by #41
Assignees
Milestone

Comments

@thanhson1085
Copy link
Contributor

thanhson1085 commented Sep 30, 2018

To simplify the flow, we should use coinbase address as unique identify.

Telegraf/grafana will use coinbase address as node identify.
For stats page, we will use node name.

So, tmn inspect just show coinbase address.

Pros:

  • one is more simple that two
  • node name will be presented on the stats page instead of unique identify, more user friendly
  • Only need to update tomomaster when user change pkey, this is a big improvement
@etienne-napoleone
Copy link
Contributor

That's actually a really good idea!
So should it be the full coinbase address (40 chars) or only a fragment?

@etienne-napoleone
Copy link
Contributor

Could be done using: https://github.com/ethereum/eth-keys

@thanhson1085
Copy link
Contributor Author

thanhson1085 commented Oct 1, 2018

40 chars is OK, it only works in background, and present in grafana.

@etienne-napoleone
Copy link
Contributor

In case we implement that, it will be a non retro-compatible release

@thanhson1085
Copy link
Contributor Author

Yep, So we need to define the steps to upgrade the version. So user can follow the steps to upgrade.
It seems we have more works need to do for this task, and masternodes need to reset the data, right?

@etienne-napoleone
Copy link
Contributor

etienne-napoleone commented Oct 16, 2018

I think so. tmn is flexible regarding changes inside the containers, but isn't when it concern changes to persistent config who is generated at first start.
Another option would be to add a flag to tmn remove to skip the volume deleting.
could be like this:

tmn remove --skip-volume
pip install -U tmn
tmn start --name ... \ # same as before or the old volume will be ignored and it will start from scratch)
          --etc...

Or maybe we could wait for those kind of stuff:

  • new networking (tested in devnet)
  • slashing
  • breaking changes in tmn

and reset testnet to get on a sane base?

@thanhson1085
Copy link
Contributor Author

We have a plan to release TomoChain version 1.0.0 in next 3 weeks (includes Penalty, Double Validation).
We will deploy the new version to the testnet, it will require the hark-folk, We hope that masternode owners do not need to reset the chain. (now syncing data will take a lot of time)

Adding more params for tmn remove and tmn start to make it more flexible, that is a good solution we have. But that will require us to write more code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants