Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make react-dom ssr section more accurate #15

Merged
merged 1 commit into from Aug 22, 2022

Conversation

Jarred-Sumner
Copy link
Contributor

Results using the same react-dom/server:

None of the runtimes are using the same build of react-dom/server, so this line is incorrect.

Node is using react-dom/server.node:

import { renderToPipeableStream } from 'react-dom/server.node';

Deno is using react-dom/server.browser:

import { renderToReadableStream } from 'https://esm.sh/v92/react-dom/server';

Bun is using what will become react-dom/server.bun:

var { renderToReadableStream } = import.meta.require('./react-dom.bun.js');

In real-world usage, it's not clear why someone would choose a build intended for a different host, so it's not particularly useful for benchmarking.

Also, we can switch bun's import.meta.require to be a regular import statement. There was a bug little while ago that has since been fixed

Are the tables manually updated? I just moved the bun row from the bottom table to the top table and removed the bottom table

@steve8708
Copy link
Contributor

Thanks @Jarred-Sumner, totally works for me. And yeah completely manual for now until we setup a proper automated way and remote (e.g. CI) env to run the results

@steve8708 steve8708 merged commit 2c01eaf into BuilderIO:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants