Make react-dom ssr section more accurate #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the runtimes are using the same build of
react-dom/server
, so this line is incorrect.Node is using
react-dom/server.node
:framework-benchmarks/frameworks/react-ssr-node/http.jsx
Line 4 in 2fb93ec
Deno is using
react-dom/server.browser
:framework-benchmarks/frameworks/react-ssr-deno/http.jsx
Line 5 in 2fb93ec
Bun is using what will become
react-dom/server.bun
:framework-benchmarks/frameworks/react-ssr-bun/http.js
Line 5 in 2fb93ec
In real-world usage, it's not clear why someone would choose a build intended for a different host, so it's not particularly useful for benchmarking.
Also, we can switch bun's
import.meta.require
to be a regularimport
statement. There was a bug little while ago that has since been fixedAre the tables manually updated? I just moved the bun row from the bottom table to the top table and removed the bottom table