Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dev script for mitosis cli #958

Closed
wants to merge 4 commits into from
Closed

feat: dev script for mitosis cli #958

wants to merge 4 commits into from

Conversation

rgodha24
Copy link

The main changes made were in the packages/cli/src/build/dev.ts file and packages/cli/src/commands/dev.ts.

Basically, it runs something like the "build" command on each file change, only on the files changed.

@vercel
Copy link

vercel bot commented Dec 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
mitosis-fiddle ✅ Ready (Inspect) Visit Preview Dec 20, 2022 at 2:34PM (UTC)

@rgodha24 rgodha24 marked this pull request as ready for review December 20, 2022 14:30
@rgodha24
Copy link
Author

I have not added tests because I'm not very good at writing them. If you could provide me with guidance, that would be great!

@rgodha24
Copy link
Author

@samijaber anything else I can do to get this pr merged?

@rgodha24 rgodha24 closed this Apr 12, 2023
@ohkimur
Copy link
Contributor

ohkimur commented Apr 17, 2023

@samijaber Isn't this feature very important? Does it need some more love? I would very much use this feature. Looking more at what it does, I don't think it should be called dev but rather it should be a --watch flag.

@rgodha24 I guess you closed this issue because it passed a long time with no answer, am I right? Would you care to reopen this issue and refactor it from dev to --watch? I'm willing to help if necessary.

@rgodha24
Copy link
Author

rgodha24 commented Apr 17, 2023

mitosis already has a "--watch" flag (I think), but that's much slower, especially when there's large amounts of files. this only rebuilds the files that are actually changed which is why I called it "dev"

@ohkimur
Copy link
Contributor

ohkimur commented Apr 17, 2023

@rgodha24 I see. Maybe we should try to improve that one instead. What do you think about that?

@kingzez
Copy link
Collaborator

kingzez commented Apr 17, 2023

It would be perfect if we supported incremental build.

@rgodha24
Copy link
Author

I'd be down to reimplement a pr starting on may 11 (my last ap test 💀).

@samijaber
Copy link
Contributor

Apologies for the delay in getting to this PR @rgodha24. This is definitely a very useful feature! And there is currently no --watch flag for mitosis build, so re-implementing this as mitosis build --dev would be very useful indeed. 🙏🏽

If you have any doubts or questions, I would suggest opening a github issue outlining how you plan on doing it so we can go over it there before a PR is put up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants