New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dev script for mitosis cli #958
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I have not added tests because I'm not very good at writing them. If you could provide me with guidance, that would be great! |
@samijaber anything else I can do to get this pr merged? |
@samijaber Isn't this feature very important? Does it need some more love? I would very much use this feature. Looking more at what it does, I don't think it should be called @rgodha24 I guess you closed this issue because it passed a long time with no answer, am I right? Would you care to reopen this issue and refactor it from dev to |
mitosis already has a "--watch" flag (I think), but that's much slower, especially when there's large amounts of files. this only rebuilds the files that are actually changed which is why I called it "dev" |
@rgodha24 I see. Maybe we should try to improve that one instead. What do you think about that? |
It would be perfect if we supported incremental build. |
I'd be down to reimplement a pr starting on may 11 (my last ap test 💀). |
Apologies for the delay in getting to this PR @rgodha24. This is definitely a very useful feature! And there is currently no If you have any doubts or questions, I would suggest opening a github issue outlining how you plan on doing it so we can go over it there before a PR is put up. |
The main changes made were in the packages/cli/src/build/dev.ts file and packages/cli/src/commands/dev.ts.
Basically, it runs something like the "build" command on each file change, only on the files changed.