Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new Image call by twitter-ads does not create HTML element #215

Open
1 task done
ghost opened this issue Jul 12, 2022 · 2 comments
Open
1 task done

new Image call by twitter-ads does not create HTML element #215

ghost opened this issue Jul 12, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jul 12, 2022

  • I am interested in helping provide a fix!

Describe the bug
Twitter ADS UWT throws error when it tries to create image e with new Image() and then access display on e.style (el.style.display = 'none'); This thrown error seems to block other scripts from being executed.

To Reproduce
Steps to reproduce the behavior:

  1. Clone 'npm run dev'
  2. Open localhost:3000
  3. Open console
  4. See error

Reproduction link
Couldn't get Codesandbox to run, so it's probably better to clone the repo. Included link just in case you get it working.

Expected behavior
No errors being thrown, image being added normally. Other scripts should execute.

Partytown version
^0.6.1

@dbashford
Copy link

dbashford commented Jul 27, 2022

Experiencing the same issue on 0.6.4

image

@adamdbradley adamdbradley added the bug Something isn't working label Aug 8, 2022
@akselander
Copy link
Contributor

Commenting for visibility as I've merged my two accounts into one and it untracked all PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants