Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keychain access #10

Closed
Bunn opened this issue Apr 15, 2017 · 2 comments
Closed

Keychain access #10

Bunn opened this issue Apr 15, 2017 · 2 comments

Comments

@Bunn
Copy link
Owner

Bunn commented Apr 15, 2017

The extension should only ask for keychain access when signing in or if the user has a token stored.
Currently it will ask on the first run since GitHubAPI().isAuthenticated is executed to define what options the extension should display to the user on SourceEditorExtension.swift
@insidegui
Copy link
Collaborator

I don't think this will happen on a signed release version of the app. The keychain dialog only appears when the app/extension is not signed or the signature has changed.

@Bunn
Copy link
Owner Author

Bunn commented Apr 19, 2017

Oh, cool. That's good to know, thanks @insidegui

@Bunn Bunn closed this as completed Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@insidegui @Bunn