Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add batch file for easy install/remove #18

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KptnKMan
Copy link

@KptnKMan KptnKMan commented May 4, 2022

I created this INSTALL/REMOVE script for easy installation/removal of the OculusKiller mod.
I have tested this script extensively, and it works without issues in all my testing on Windows 10 with latest updates.

The use of this script is pretty easy, create a folder anywhere, and place the modified OculusDash.exe and this script in that folder.
This folder can be anywhere on your PC, I created a folder in My Documents, and run it from there. You could put it anywhere, as long as the modified OculusDash.exe is there as well.

Always run the script AS ADMINISTRATOR, or you will get an "Access Denied" error.
I would recommend including this script with further releases, as a combined zip file which will make install and removal easy.

@dinckelman
Copy link

There's a really big issue with this workaround. It assumes that your oculus server is installed in the default location. Without giving path manually, or setting Oculus path into $PATH, as far as I can't tell, you can't determine that at runtime

@UnusualNorm
Copy link
Collaborator

UnusualNorm commented May 9, 2022

@dinckelman Good point, on that note. We do in fact have a way to check that, we have the OCULUSBASE environment variable!

@KptnKMan Instead of pre-defining the Oculus installation location, please make use of the OCULUSBASE environment variable to determine where to place files.

@dinckelman
Copy link

Thanks for the heads-up. I'm in the middle of fixing this, so hang tight for a patch. Should be ready soon

@dinckelman
Copy link

dinckelman commented May 9, 2022

Patch submitted, waiting on @KptnKMan to approve the PR here.

Furthermore, this can be updated again, to check latest release hash against what's currently installed. With what we have now, the script simply checks if there's a backup present, and if so, it'll ask what to do. We all know that assumptions are bad, so it'd make sense to check what is actually in the folder

@KptnKMan
Copy link
Author

KptnKMan commented May 9, 2022

Copy and Paste of the same comment from the patch:

So I think the point of this script purposefully NOT being Powershell is missed here.
Powershell is great and all and I could have done that, but because of Powershells own greatness, there are often issues with Powershell scripts (PSVersion, Execution Permissions, Libraries, etc).
The point is this script was written PURPOSEFULLY in batch because it runs with better compatibility and different versions of Windows.

I have updated the script after I saw the first comment, but I didn't see the rest until now.
I have also added additional functionality to detect if the OCULUSBASE variable exists, and create it (per users permission by asking the user). Also, a custom path can be entered, and that can be written as a System Var as well if desired.

Again, the point is that batch is more compatible with more systems, and I think it will work for more people, and easier, without then needing to configure Powershell first.

So, the patch is rejected.
But you can submit your own PR, matters not to me.

On a final note, it would have taken like 2 lines extra just to add %OCULUSBASE% but hey, lets use our Powershell skills I guess.

@KptnKMan
Copy link
Author

KptnKMan commented May 9, 2022

I've also made sure to test this script on different Windows OSs because not everyone uses latest Windows 10.
Windows 10 and Windows 7 should work, again, without the Powershell shenanigans.

The purpose is compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants