Update examples to use external hostname on AWS #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Kubernetes' LoadBalancerIngress object contains both an
ip
and ahostname
field. GKE sets theip
field, but DNS-based ingress (AWS loadblancers) set thehostname
field. All of our existing examples in the k8s-daemonset dir assume thatip
is set, and ignore thehostname
field.Solution
Update our examples with a jsonpath syntax that will read either
ip
orhostname
, depending upon which one is set.Aside
In testing these changes, I realized that we were unnecessarily setting the
hostPort
option on ports that do not need to have fixed port on the node where they are running. I've removed that where it's appropriate.Fixes #78.