Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to use external hostname on AWS #86

Merged
merged 1 commit into from Feb 9, 2017
Merged

Conversation

klingerf
Copy link
Member

@klingerf klingerf commented Feb 9, 2017

Problem

Kubernetes' LoadBalancerIngress object contains both an ip and a hostname field. GKE sets the ip field, but DNS-based ingress (AWS loadblancers) set the hostname field. All of our existing examples in the k8s-daemonset dir assume that ip is set, and ignore the hostname field.

Solution

Update our examples with a jsonpath syntax that will read either ip or hostname, depending upon which one is set.

Aside

In testing these changes, I realized that we were unnecessarily setting the hostPort option on ports that do not need to have fixed port on the node where they are running. I've removed that where it's appropriate.

Fixes #78.

Copy link
Contributor

@esbie esbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@klingerf klingerf merged commit 4409918 into master Feb 9, 2017
@klingerf klingerf deleted the kl/ingress branch February 9, 2017 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error : ip is not found while trying to open linkerd admin dasboard
2 participants