Changed build requirements packages for Centos #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmberg
reviewed
Nov 18, 2020
README.md
Outdated
| yum install fuse-python pyxattr | ||
| yum install perl-Time-HiRes | ||
| yum install readline-devel # optional (bup ftp) | ||
| yum install python-tornado # optional (bup web) | ||
| yum install python-tornado-doc # optional (bup web) |
There was a problem hiding this comment.
that seems odd, why would we care about the documentation?
There was a problem hiding this comment.
If we don't care, I can change it like it was earlier.
|
...and once we've consider jmberg's question, would you be comfortable with a Signed-off-by psuedo-header in the commit? https://github.com/bup/bup/blob/master/SIGNED-OFF-BY Thanks |
|
@rlbdv Sure. |
Some packages have been changed the name, so building bup was problematic. Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
|
Do we care about Centos 8? Current package build is focused on Centos 7. |
|
Without knowing Centos well, I'd imagine ideally, we'd probably want to focus (at least) on whatever the current stable release is. |
|
Incorporated as ec26ee2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some packages have been changed the name, so
building bup was problematic.
We discuss code changes on the mailing list bup-list@googlegroups.com,
but if you'd prefer to begin the process with a pull request, that's
just fine. We're happy to have the help.
In any case, please make sure each commit includes a
Signed-off-by: Someone someone@some.where
line in the commit message that matches the "Author" line so that
we'll be able to include your work in the project. See
./SIGNED-OFF-BY for the meaning:
https://github.com/bup/bup/blob/master/SIGNED-OFF-BY
After you submit the pull request, someone will eventually redirect it
to the list for review, and you will of course be included in the
conversation there.
On the other hand, if you're comfortable with "git send-email" (or the
equivalent), please post your patches to the list as described in the
"Submitting Patches" section in ./HACKING:
https://github.com/bup/bup/blob/master/HACKING