Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggested additions to readme #31

Closed
kgilmer opened this issue Jul 10, 2022 · 2 comments
Closed

Suggested additions to readme #31

kgilmer opened this issue Jul 10, 2022 · 2 comments
Assignees
@Burnett01
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@kgilmer
Copy link

kgilmer commented Jul 10, 2022

Thanks for your work, I have a few minor suggestions that may help others when evaluating your action:

  • Document that path is relative to the github workspace. This means that only sub-paths of the workspace may be uploaded.
  • Document that the action can only run on amd64 hosts. arm build hosts cannot use this action.
@Burnett01
Copy link
Owner

Hey @kgilmer Thank you very much. I will adjust the readme. Greetings Steve

Burnett01 added a commit that referenced this issue Jul 30, 2022
@Burnett01
Update with suggestions from #31
d2a4efa 
#31
@Burnett01
Copy link
Owner

Done in d2a4efa.
Thank you again.

@Burnett01 Burnett01 self-assigned this Jul 30, 2022
@Burnett01 Burnett01 added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Jul 30, 2022
@Burnett01 Burnett01 mentioned this issue Aug 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Burnett01 Burnett01

Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kgilmer @Burnett01