Examples [WIP] #10
Examples [WIP] #10
Conversation
| @@ -0,0 +1,61 @@ | |||
| // This is a buggy quick sort implementation, QuickSort will find the bug for you | |||
|
@moonglum Hey, so you've picked an interesting time to submit PRs. We're in the middle of a hackathon and @huon has packaged this crate up to be submitted to Rust proper. Here's his fork: https://github.com/huonw/rust/tree/quickcheck Would you mind submitting your em-dash PR to that fork? I'm not sure if the examples made it in. |
| result.push(x.clone()); | ||
| result.extend(ys.iter().map(|x| x.clone())); | ||
| result | ||
| } |
There was a problem hiding this comment.
I think you might find the append and append_one methods (on the Vec type) useful here.
|
I'm actually at that hackathon! 馃槃 I will do that! |
|
@moonglum Oh, awesome! |
|
About the other PR: Not sure if that applies any longer as the Markdown will now no longer be parsed by Github, but my the Rust Documentation Tool. I don't know if it has the same bug 馃槈 |
|
Thanks for all your feedback, I will work it into a new version. Where will the examples be in the future? |
|
@moonglum just add them to the doc comment of the main lib.rs file: e.g. add a "# More examples" (or "# Case study: sorting") section at https://github.com/huonw/rust/blob/quickcheck/src/libquickcheck/lib.rs#L373-L374 . |
|
@BurntSushi Thank you so much for your feedback! Helped a lot. What do you think? Do you still see things to be improved? @huonw Cool! I will do that! |
|
It seems to be a little tricky to send pull requests to a repository that's not the source of a fork (i.e. if a fork of rust comes from mozilla/rust then others haven't been able to submit PRs to huonw/rust). Feel free to just push the commit to a normal branch and put a link to that here; I'll cherry pick it to put it in rust-lang/rust#14100. |
|
@BurntSushi can this be merged now? |
|
Sorry about the late merge, but better late than never. :-) |
|
Thanks 馃憤 |
Ok, next pull request coming up!
I've build a buggy version of a quicksort implementation with a quite common bug (neither the
smaller_thannor thelarger_thanpart include the "equal" part). QuickCheck will find this bug.I also added a more descriptive name to the invariant on your
reverseexample. I hope you like it 馃槈Work in Progress: I don't know how elegant my implementation is. I tried to keep it to my Haskell implementation, which is only 5 lines. This implementation gets kinda messy with conversions between vectors and ranges. I will ask for feedback in the Rust IRC 馃憤