Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug_reprs taking up 41% of test runtime #303

Open
davidrusu opened this issue Dec 30, 2021 · 2 comments · May be fixed by #304
Open

debug_reprs taking up 41% of test runtime #303

davidrusu opened this issue Dec 30, 2021 · 2 comments · May be fixed by #304

Comments

@davidrusu
Copy link

davidrusu commented Dec 30, 2021

It seems like we're formatting the test case arguments even on passing test runs, e.g. here is the flamegraph of a test run where the test passed, but we see 41% of runtime spent building up debug_reprs.

image

Does this make sense to you? do you see a way of modifying the test runner to only render the debug representation on failure?

@BurntSushi
Copy link
Owner

I'm not sure off the top of my head and this isn't high on my priority list. I would encourage you to investigate.

@davidrusu
Copy link
Author

I think I have a solution in #304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants