Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support indefinite-length arrays, maps, and strings #17

Merged
merged 1 commit into from Jul 24, 2018

Conversation

glguy
Copy link
Contributor

@glguy glguy commented Jul 13, 2018

I've been using this code on the c2rust project pretty extensively for the last year after bringing it up in #12 It'd be neat to fold it back into the project!

@BurntSushi
Copy link
Owner

Thanks! Would you mind rebasing and squashing this down to one commit? Could you also clean up the formatting so that it's consistent with the rest of the code and limited to 79 columns inclusive? Thanks!

@glguy
Copy link
Contributor Author

glguy commented Jul 14, 2018

@BurntSushi PR updated

@glguy
Copy link
Contributor Author

glguy commented Jul 24, 2018

@BurntSushi Is there anything I can do to get this to a state worth merging?

@BurntSushi
Copy link
Owner

I'm not really maintaining this crate any more. With that said, the CI is green and the change is somewhat small and reasonable, so I'll merge this and push out a new release.

In general though, you should consider a different long term option for CBOR in Rust. The fact that this is still using rustc-serialize is alone enough of a reason to pass on it IMO.

@BurntSushi BurntSushi merged commit 56f8bb2 into BurntSushi:master Jul 24, 2018
@BurntSushi
Copy link
Owner

cbor 0.4.1 is on crates.io.

@glguy
Copy link
Contributor Author

glguy commented Jul 24, 2018

Thanks. As far as I can see there isn't a better option in the Rust ecosystem for just manipulating raw CBOR data. This package seems to do a perfectly good job. I don't know enough about rusts-serialize to know what the issue is there.

I appreciate the upload!

@BurntSushi
Copy link
Owner

As far as I can see there isn't a better option in the Rust ecosystem for just manipulating raw CBOR data.

That may be, which means a better long term option might be writing your own or fork this crate and assuming maintenance for it.

I don't know enough about rusts-serialize to know what the issue is there.

rustc-serialize is the (very) old way of doing type directed serialization and deserialization. It was supplanted quite some time ago by serde. There is even a CBOR crate with Serde support that seems to be somewhat actively maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants