-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid import links don't appear in output #71
Comments
Hmm, I could do that, but I was rather thinking of calculating difference between source and output location and modifying every |
Oh right, I didn't think about that. Definitely a good idea to have links transformed so that they work in output dir, if it's different. But still I wouldn't remove any links if they are invalid... |
Not a problem at all :). Thought it was better to not emit invalid imports, but it might actually be unwanted. I will however add a flag, sort of |
My thinking is that you can run into trouble when a link would actually be valid but incorrectly classified. Also, absolute HTTP hrefs (cdn?) And I'd call the flag |
Non-relative paths (cdns, absolute) are pretty easy to check, relative are much worse due to changing physical position. |
I don't know. Maybe it's safe to assume that links will usually match a physical location relative to source or destination folder? |
Yea it might be the best thing to do, at least for now. Nevertheless, I will not strip invalid links as you suggested :). |
Fixed in #74. |
Related to #57, I see that v0.1.12-beta.1 shows warning when an import is invalid but it also doesn't put those imports in the JS output.
For example, when I have
import 'link!../../polymer/polymer.html';
in a processed file, it gives the warning but not<link>
in output.It is obvious that such imports are invalid at build time of element project. I think that twc should fall back to looking in
bower_component
to see if the path would actually resolve tobower_components/polymer/polymer.html
.Do you think it's also worth observing
.bowerrc
in case the components folder has a non-default name?The text was updated successfully, but these errors were encountered: