Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot include empty folders #96

Closed
rnixx opened this issue Nov 10, 2022 · 2 comments
Closed

Cannot include empty folders #96

rnixx opened this issue Nov 10, 2022 · 2 comments

Comments

@rnixx
Copy link

rnixx commented Nov 10, 2022

Python's zipfile module supports writing empty folders to zip archive.

when trying with zipfly i get:

File "/.../zipfly.py", line 211, in generator
    with open( path[self.filesystem], 'rb' ) as e:
IsADirectoryError: [Errno 21] Is a directory: '/path/to/dir'

Is there an undocumented way for writing empty folders?

@sandes
Copy link
Owner

sandes commented Nov 10, 2022

Hello,
It doesn't make any sense to include an option to add empty folders in zipfly.

You always can open a pr :)

@rnixx
Copy link
Author

rnixx commented Nov 11, 2022

Well, there are valid usecases. This is no question about "sense".

@rnixx rnixx closed this as completed Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants