Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SimpleMergeSelector settings configuration #913

Open
zhaojintaozhao opened this issue Dec 1, 2023 · 1 comment
Open

Add SimpleMergeSelector settings configuration #913

zhaojintaozhao opened this issue Dec 1, 2023 · 1 comment
Assignees
@gaodayue
Labels
enhancement New feature or request

Comments

@zhaojintaozhao
Copy link
Contributor

Hi All,
We can set merge configuration of DanceMergeSelector, but we can not set set merge configuration of SimpleMergeSelector. So I want to add SimpleMergeSelector settings configuration to speed merge.
@zhaojintaozhao zhaojintaozhao added the enhancement New feature or request label Dec 1, 2023
@zhaojintaozhao zhaojintaozhao mentioned this issue Dec 1, 2023
Open
@GallifreyY
Copy link
Collaborator

GallifreyY commented Dec 4, 2023 •
edited

hi @zhaojintaozhao
Currently all the SimpleMergeSelector related settings is in here: SimpleMergeSelector.h
It can be over written by:
max_parts_to_merge_at_once
max_total_rows_to_merge
referenced in here: selectPartToMerge.cpp
Is there any other configs needed to add? cc @gaodayue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaodayue gaodayue

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gaodayue @GallifreyY @zhaojintaozhao