Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[git-ref] change edits after prepare() #181

Closed
Tracked by #104
Byron opened this issue Aug 27, 2021 · 2 comments
Closed
Tracked by #104

[git-ref] change edits after prepare() #181

Byron opened this issue Aug 27, 2021 · 2 comments
Labels
wontfix This will not be worked on

Comments

@Byron
Copy link
Owner

Byron commented Aug 27, 2021

Find a helpful API do help in these cases:

radicle-dev/radicle-link#761 (comment)

@Byron
Copy link
Owner Author

Byron commented Aug 27, 2021

CC @kim I will implement as part of the still ongoing 🤦‍♂️ git fetch work block as I think it's valuable to lock the refs-to-be-fetched to prevent racy fetches, and change the tips to the then known location once the fetch is complete. This would naturally prevent fetching the same heads in multiple processes as well.

@Byron
Copy link
Owner Author

Byron commented Sep 1, 2021

Let's rather retry even if this means that potentially expensive computation has to be redone.
For now we assume such optimizations aren't worth it, but it's OK to revisit this once actual data from a busy server is available.

@Byron Byron closed this as completed Sep 1, 2021
Collaboration Board automation moved this from To do to Done Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant