New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename the serde1 feature to serde #814

Merged

Byron merged 1 commit into Byron:main from vilgotf:weak-deps

Apr 17, 2023

Contributor

vilgotf commented Apr 16, 2023

Uses Cargo weak-deps (stabilized in 1.60) to declare serde and thus avoid the awkward serde1 feature.

Ok for Byron review the PR on video?

I give my permission to record review and upload on YouTube publicly

If I think the review will be helpful for the community, then I might record and publish a video.


          rename the serde1 feature to serde

19338d9

Byron merged commit b83ee36 into Byron:main

16 checks passed

Owner

Byron commented Apr 17, 2023

Thanks a lot for putting in the work needed to make the transition, it's much appreciated :)!

vilgotf deleted the weak-deps branch

April 17, 2023 12:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment