Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Fix up @types node package incorrectly involved in dependencies, closes #774 #838

Merged
merged 1 commit into from Dec 27, 2023

Conversation

zackerydev
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Have you added tests for the new feature
  2. Does your submission pass tests?
  3. Have you lint your code locally prior to submission?
  4. Have you updated the docs?
    • If you added new parsing or formatting options have you added them to the docs?
    • If applicable have you added an example to the parsing or formatting docs?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@c2fo-cibot c2fo-cibot bot added the size/XS Denotes a PR that changes 0-9 lines label Dec 27, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7341100372

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.351%

Totals Coverage Status
Change from base Build 7341086308: 0.0%
Covered Lines: 752
Relevant Lines: 770

💛 - Coveralls

@zackerydev zackerydev merged commit 83315a6 into master Dec 27, 2023
6 checks passed
@zackerydev zackerydev deleted the zackerydev/fix-types-node branch December 27, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants