Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs plan is broken #311

Closed
jonasjucker opened this issue Nov 3, 2021 · 3 comments
Closed

Docs plan is broken #311

jonasjucker opened this issue Nov 3, 2021 · 3 comments
Labels
bug Something isn't working high-prio

Comments

@jonasjucker
Copy link
Contributor

Since the merge of #305
the docs PR is broken. Needs a fix.
@jonasjucker jonasjucker added bug Something isn't working high-prio labels Nov 3, 2021
@dominichofer
Copy link
Contributor

I think this is the same (kind of) bug we hit:
sphinx-doc/sphinx#9811

@cosunae
Copy link
Contributor

cosunae commented Nov 5, 2021

This thread explains the problem
sphinx-doc/sphinx#9727
the solution recommended is to upgrade to sphinx v4.0 which pins the version of docutils (since 0.18) is the one that breaks.

However the action we are using is pinned to v2.4.4
https://github.com/ammaraskar/sphinx-action/blob/35082eb35b69713fe335801c4d5846a4cc3c91ff/Dockerfile#L1

ammaraskar/sphinx-action#25

upgrading fixes the problem:
#316

perhaps we should use our own fork for the action ?

@jonasjucker
Copy link
Contributor Author

For me its fine to use an own fork. But someone has to take care of it right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working high-prio
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cosunae @dominichofer @jonasjucker