-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
553 add routeviews data #639
Conversation
…iews data paper yaml
…ce add routeviews to three scripts
I get the following error messages when I try to make it:
|
I believe this is a typo in the Makefile. The |
Yes please.
… On Jun 21, 2023, at 6:13 PM, David Tran ***@***.***> wrote:
I believe this is a typo in the Makefile. The routerviews target is no longer needed and has been removed. Should I also fix the "unparseable" errors above? They are a result of missing authors/information for these papers on routeviews.org where I scraped from to generate the routeviews yaml.
—
Reply to this email directly, view it on GitHub <#639 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AECPT7PBY4RPEL32MN4SAPTXMOL4HANCNFSM6AAAAAAZLEFWQU>.
You are receiving this because you commented.
|
It looks like there's no way to fix the remaining unparseable errors without editing the For example, the first unparseable paper has authors |
Make a list of papers that are broken. We will email routeviews and have them fix it on their end. |
Of these unparseable papers, these two should be corrected if possible: Both of the remaining unparseable papers has author "CAIDA". I fixed the issues with "CAIDA" author by fixing my script that generates the routeviews yaml. The external placeholder script is able to handle single-name authors just fine. Happy Fourth of July! |
The caida paper should match against papers generated from pubdb. You will need to change the Makefile, so that it generates the papers from pudb before your code is called. It will then need to check the files generated in sources/papers and not ignore duplicates. |
What do you mean by not ignore duplicates? What should I do if there is a duplicate paper? Would this be similar to merging duplicates like we discussed before (take union of keys)? |
Actually, just skip those papers for now. |
Ok, the "CAIDA" author papers should be skipped now. There should only be two unparseable papers. (Edit: it is not showing up here, but I did push to the 553 branch ) |
What are those papers?
… On Jul 4, 2023, at 10:15 PM, David Tran ***@***.***> wrote:
Ok, the "CAIDA" author papers should be skipped now. There should only be two unparseable papers.
—
Reply to this email directly, view it on GitHub <#639 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AECPT7OSV6V7O66JHSPDQL3XOTZ7HANCNFSM6AAAAAAZLEFWQU>.
You are receiving this because you commented.
|
They are:
|
do you mean you don't know what to map them too?
|
I think I am misunderstanding your previous comments. This is how I interpreted our discussion:
With commit A: The two papers are included in the routeviews yaml. Then, they will be parsed correctly by the placeholder script and placeholder objects will be created for them. With commit B: These papers are effectively ignored. Is there something else missing that should done for this issue? |
Please remove debugging error messages:
Resolve error messages:
|
Closes #553. Adding routeviews data works with updated Makefile and uses three scripts.
scripts/externallinks_placeholder.py
checks for and merges duplicate papers in two input yaml's.