Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recipe:map_ipv4_address_to_asn #724

Open
bhuffaker opened this issue Dec 1, 2023 · 6 comments · May be fixed by #726
Open

fix recipe:map_ipv4_address_to_asn #724

bhuffaker opened this issue Dec 1, 2023 · 6 comments · May be fixed by #726
Assignees

Comments

@bhuffaker
Copy link
Member

https://catalog.caida.org/recipe/map_ipv4_address_to_asn

  • fix the recipe so it has the user go through the dataset page
    • then have them download the file, tell them how to find it
    • update the script so it uses the downloaded file
@trdavidt
Copy link
Contributor

trdavidt commented Dec 5, 2023

The recipe also includes an alternative script that uses a downloaded file, but uses pyasn instead of pyipmeta. I have kept this one as is, arguments for both scripts should be the same. The only changes I made were to the README and ip_asn_pyipmeta.py.

@bhuffaker
Copy link
Member Author

@richmass1 please replicate the https://github.com/CAIDA/catalog-data/tree/724-fix-recipe-ipv4-to-asn/sources/recipe/map_ipv4_address_to_asn

  • you should understand what the recipe is trying to do
  • run the code

@richmass1
Copy link
Contributor

What the code does: produce a mapping from a provided list of IPv4 addresses to their associated ASNs
I was able to run the code. Some things I noticed:

  • In the README, it says the pfx2as file should be specified with the -f flag, but in the code it's -p
  • The link for sample IPs prompts me for a username and password; perhaps a more accessible example should be provided
  • The code does not print the mapping (it looks like it's not supposed to)

@bhuffaker
Copy link
Member Author

  • In the README, it says the pfx2as file should be specified with the -f flag, but in the code it's -p

Please update change the README to match the code.

  • The link for sample IPs prompts me for a username and password; perhaps a more accessible example should be provided

ip link worked for me?

  • The code does not print the mapping (it looks like it's not supposed to)
    please update the code so it prints out the mapping, or change the README so it says "How to load a mapping between IP and ASN into memory.

@richmass1
Copy link
Contributor

I changed the README and also uncommented the print statement. The sample IP link still prompts me for a username and password, but if I change domain name from data.caida.org to publicdata.caida.org it works. Should I put that in the README?

@bhuffaker
Copy link
Member Author

bhuffaker commented Dec 16, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants