You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The equality operators for ProgramSettings use a GetTuple function which hasn't been updated to include new fields (so they no longer actually check for equality). The equality operator is only used in the empty arguments test of the settings class. Adding more of the fields causes the test to fail, because e.g. event_thread_count is set to a new value dynamically when CARTA is run with no parameters.
Either the test needs to be revised to work with an operator which correctly checks for equality, or the operator should be removed from the main codebase and replaced with a test function which is more specifically tailored to the test.
I will commit a proof of concept updated equality operator to a branch.
The text was updated successfully, but these errors were encountered:
The equality operators for
ProgramSettings
use aGetTuple
function which hasn't been updated to include new fields (so they no longer actually check for equality). The equality operator is only used in the empty arguments test of the settings class. Adding more of the fields causes the test to fail, because e.g.event_thread_count
is set to a new value dynamically when CARTA is run with no parameters.Either the test needs to be revised to work with an operator which correctly checks for equality, or the operator should be removed from the main codebase and replaced with a test function which is more specifically tailored to the test.
I will commit a proof of concept updated equality operator to a branch.
The text was updated successfully, but these errors were encountered: