Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading FITS Images from NED Hangs CARTA #1063

Closed
jmangum opened this issue Feb 19, 2021 · 7 comments · Fixed by #1127
Closed

Loading FITS Images from NED Hangs CARTA #1063

jmangum opened this issue Feb 19, 2021 · 7 comments · Fixed by #1127
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jmangum
Copy link

jmangum commented Feb 19, 2021

Using CARTA v1.4 server find that trying to load a FITS image from NED, specifically the FITS image at http://ned.ipac.caltech.edu/uri/NED::Image/fits/2009A+A...506.1123H/NGC_0253:I:vla+eff_6_cm_I_30arcs:H2009, hangs CARTA. Never completes loading image, with spinning arrow display trying to show file information.

@kswang1029
Copy link
Contributor

kswang1029 commented Feb 20, 2021

Thanks for reporting the issue. Recently we have improved the FITS header parser so the example image mentioned above can already be loaded successfully in the latest dev branch. The fix will be included in the next release due May/June.

@jmangum
Copy link
Author

jmangum commented Feb 20, 2021

Thank you. Is there a workaround? Waiting 3-4 months for an update to an obvious bug like this seems extreme.

@kswang1029
Copy link
Contributor

kswang1029 commented Feb 20, 2021

Not sure if there is something in the HISTORY (there are 43949 lines of HISTORY!) causing the issue. If we remove all the HISTORY, then the image can be loaded (as attached).
NGC_0253_I_vla+eff_6_cm_I_30arcs_H2009.fits.zip
Screen Shot 2021-02-20 at 8 29 01 PM

@pford do you know if such long HISTORY in FITS header could possibly cause problem from casacore (RAM?)?
@veggiesaurus can the protocol buffer message carry such long list of FITS header? (UPDATE: I think it is unlikely due to protobuf message as the current dev branch can handle it).

@jmangum
Copy link
Author

jmangum commented Feb 20, 2021

Thank you. Removing the HISTORY fixes the problem.

@veggiesaurus
Copy link
Collaborator

Thank you. Is there a workaround? Waiting 3-4 months for an update to an obvious bug like this seems extreme.

@jmangum is this a CARTA server deployed by NRAO? You could ask them to also put together a bleeding-edge deployment of CARTA? We normally update the dev package for carta-controller every couple of weeks

@jmangum
Copy link
Author

jmangum commented Feb 22, 2021

Thank you. Not using an NRAO CARTA server. I think that removing the history is a reasonable workaround for now.

@kswang1029
Copy link
Contributor

with v3b2 loading the example image still hangs. As a reference, ds9 loads the image instantly.

@kswang1029 kswang1029 transferred this issue from CARTAvis/carta Mar 17, 2022
@kswang1029 kswang1029 added the bug Something isn't working label Mar 17, 2022
@veggiesaurus veggiesaurus added this to the v3.0-stable milestone Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants