Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loading images via LEL may fail or may be unexpectedly successful #1144

Closed
kswang1029 opened this issue Jul 9, 2022 · 3 comments · Fixed by #1146
Closed

loading images via LEL may fail or may be unexpectedly successful #1144

kswang1029 opened this issue Jul 9, 2022 · 3 comments · Fixed by #1146
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kswang1029
Copy link
Contributor

kswang1029 commented Jul 9, 2022

Describe the bug
The directory path in OPEN_FILE message does not update when directory changes. This results in

  1. cannot load an image via LEL
  2. can load an image via LEL, which does not exist in the current directory

Demo of 1)
Firstly, try to load an image which does not exist in the current directory. It will fail as expected. Then navigate to the directory which contains the image that we just tried to load. It should load but we see it failed.

Untitled1.mov

Demo of 2)
Firstly, try to load an image which does exist in a directory. It will load and it does. Then navigate to other directory which does not contain the same image we just loaded. It should fail but we see it loads successfully.

Screen.Recording.2022-07-09.at.11.18.17.mov

Platform info (please complete the following information):

  • OS [e.g. macOS Monterey]: macOS Monterey
  • Browser [e.g. chrome, safari, electron app]: chrome
  • Browser version [e.g. 22]: 103
  • Backend branch [e.g. dev, v3b2 release]: dev
  • Frontend branch [e.g. dev, v3b2 release]: dev
@kswang1029 kswang1029 added the bug Something isn't working label Jul 9, 2022
@kswang1029
Copy link
Contributor Author

@veggiesaurus This is an issue reported by a v3 beta tester (and sorry I did not pick it up at the time of implementation 🙈). Would you be able to squeeze some time to investigate this? Would be nice to fix this for v3-final if possible.

@kswang1029
Copy link
Contributor Author

Actually, I see identical OPEN_FILE message context in the two cases. So this is probably a backend issue instead. Transferring to backend repo.

@kswang1029 kswang1029 transferred this issue from CARTAvis/carta-frontend Jul 9, 2022
@kswang1029
Copy link
Contributor Author

@markccchiang would you be able to investigate this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants