Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[critical for v3-stable release] cannot navigate through file system when trying to load a region file #1159

Closed
kswang1029 opened this issue Jul 27, 2022 · 6 comments · Fixed by #1162
Assignees
Labels
critical bug critical bug which is a showstopper for release

Comments

@kswang1029
Copy link
Contributor

Describe the bug
This is considered as a regression which I did not pick up from #1142. Apologies...

With #1142, only region files are listed in the directory. However, if we need to navigate to other parent folders with the breadcrumbs, there is no way to access folders therein as they are filtered out.

To Reproduce
Steps to reproduce the behavior:

  1. try to load a region file in a parent directory with the file browser
  2. no directory is visible from the file list

Expected behavior
We still need to show directories so users can navigate through the file system to load a region file.

Platform info (please complete the following information):

  • OS [e.g. macOS Monterey]: macOS Monterey
  • Browser [e.g. chrome, safari, electron app]: chrome
  • Browser version [e.g. 22]: 103
  • Backend branch [e.g. dev, v3b2 release]: dev
  • Frontend branch [e.g. dev, v3b2 release]: dev
@kswang1029 kswang1029 added the critical bug critical bug which is a showstopper for release label Jul 27, 2022
@kswang1029
Copy link
Contributor Author

@pford could you have a look please? My bad not being able to pick it up in #1142.

@veggiesaurus
Copy link
Collaborator

@kswang1029 what is the backend sending to the frontend? Are we sure it's not sending directories and the frontend is filtering them out?

@kswang1029
Copy link
Contributor Author

@kswang1029 what is the backend sending to the frontend? Are we sure it's not sending directories and the frontend is filtering them out?

It seems so.

Screen Shot 2022-07-27 at 15 16 41

@pford pford self-assigned this Jul 27, 2022
@pford
Copy link
Collaborator

pford commented Jul 27, 2022

@kswang1029 what should happen when the filter is "All Files" (no content checking) and there is a CASA image? Should it be (1) listed with other directories, (2) listed as CASA, or (3) determined that it is an image and not list it?

@pford
Copy link
Collaborator

pford commented Jul 27, 2022

I went with option 1 since the point of All Files is speed.

@kswang1029
Copy link
Contributor Author

I went with option 1 since the point of All Files is speed.

Yes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical bug critical bug which is a showstopper for release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants