Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase the upper limit of the averaging width for line and polyline regions (backend) #1174

Closed
kswang1029 opened this issue Aug 4, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request requiring frontend this backend issue requires work in both frontend and backend

Comments

@kswang1029
Copy link
Contributor

kswang1029 commented Aug 4, 2022

user feedback from v3 beta test

With the v3 release, the upper limit of the averaging width for line and polyline analytics is 10. Users would like to have a greater upper limit (20) so that they can apply averaging more than one beam width (some users prefer oversampling a beam element).

The companion frontend issue is CARTAvis/carta-frontend#1949

@markccchiang
Copy link
Contributor

I think the backend does not stick to the upper limit of averaging width to 10. It could be solved by simply modifying the frontend and setting the max averaging width to 20. I have created a testing frontend branch mark/1949_increase_the_width_upper_bound and it works fine to me so far.

@kswang1029
Copy link
Contributor Author

I think the backend does not stick to the upper limit of averaging width to 10. It could be solved by simply modifying the frontend and setting the max averaging width to 20. I have created a testing frontend branch mark/1949_increase_the_width_upper_bound and it works fine to me so far.

I see. Me overthinking the problem! Would you file a frontend PR then?

@pford
Copy link
Collaborator

pford commented Sep 1, 2022

I did not think about checking the width since the value comes from the frontend which will not go over the limit. But the check should be added to the backend if this will be supported by scripting, where the width could be any crazy number.

@kswang1029
Copy link
Contributor Author

I did not think about checking the width since the value comes from the frontend which will not go over the limit. But the check should be added to the backend if this will be supported by scripting, where the width could be any crazy number.

good point. Shall we hardcode an upper limit of 20? @markccchiang

@kswang1029
Copy link
Contributor Author

this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request requiring frontend this backend issue requires work in both frontend and backend
Projects
None yet
Development

No branches or pull requests

3 participants