Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PV generator: support spatial as x and spectral as y AND spatial as y and spectral as x (backend) #1175

Closed
kswang1029 opened this issue Aug 4, 2022 · 1 comment
Closed

PV generator: support spatial as x and spectral as y AND spatial as y and spectral as x (backend) #1175

kswang1029 opened this issue Aug 4, 2022 · 1 comment
Assignees
@pford
Labels
enhancement New feature or request requiring frontend this backend issue requires work in both frontend and backend
Milestone
v4.0-b1

Comments

@kswang1029
Copy link
Contributor

kswang1029 commented Aug 4, 2022 •
edited
Loading

user feedback from v3 beta test

This is an enhancement that users can configure the axes order of the resulting pv image from the pv generator. With v3 release, the offset axis is in x and the spectral axis is in y. We need to provide an option to generate a pv image with the offset axis in y and the spectral axis in x.

This requires protobuf message update.

The companion frontend issue is CARTAvis/carta-frontend#1950
@kswang1029 kswang1029 added the enhancement New feature or request label Aug 4, 2022
@kswang1029 kswang1029 mentioned this issue Aug 4, 2022
Closed
@kswang1029 kswang1029 added the requiring frontend this backend issue requires work in both frontend and backend label Aug 4, 2022
@kswang1029 kswang1029 mentioned this issue Sep 7, 2022
Closed
@pford
Copy link
Collaborator

pford commented Sep 7, 2022

I think this could be a simple boolean reverse flag in PvRequest, with false being the current implementation.

@pford pford added this to the v4.0-b1 milestone Sep 13, 2022
@pford pford mentioned this issue Sep 14, 2022
Merged
6 tasks
@pford pford closed this as completed Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pford pford

Labels
enhancement New feature or request requiring frontend this backend issue requires work in both frontend and backend
Projects
None yet
Milestone
v4.0-b1
Development

No branches or pull requests
2 participants
@pford @kswang1029