Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to keep or replace generated moment images when a new request is made (backend) #1202

Closed
pford opened this issue Sep 28, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request requiring frontend this backend issue requires work in both frontend and backend
Milestone

Comments

@pford
Copy link
Collaborator

pford commented Sep 28, 2022

Split from #1176 , now for PV images only. This is for moment images only.

@pford pford added enhancement New feature or request requiring frontend this backend issue requires work in both frontend and backend labels Sep 28, 2022
@pford pford added this to the v4.0-b1 milestone Sep 28, 2022
@pford pford self-assigned this Sep 28, 2022
@pford
Copy link
Collaborator Author

pford commented Sep 28, 2022

Created protobuf branch moment_keep_option

@pford
Copy link
Collaborator Author

pford commented Sep 28, 2022

@kswang1029 each moment can be requested individually and has a unique name, i.e. "image.moment.average", "image.moment.integrated", etc. We can append an index to these names, as in PV image, but are the frontend/backend required to keep track of which moments have been generated? Or is it indexed by generation?

For example, the user requests mom -1 keep=false ("image.average"), then mom 0 keep=true ("image.integrated" or "image.integrated1"?), then mom -1, 0, 1 keep=true ("image.averageX", "image.integratedX" , "image.weighted_coordX" - what is X for each?).

@pford
Copy link
Collaborator Author

pford commented Sep 28, 2022

I just pushed a branch for an initial implementation, where the index is incremented each time keep=true for all generated moment images, but this can be changed.

So in my previous example (assuming I got the names right for the moment numbers!) you would get:

  • mom -1 keep=false: image.average
  • mom 0 keep=true: image.integrated1
  • mom -1, 0, 1 keep=true: image.average2, image.integrated2 , image.weighted_coord2

When keep=false, there is no index appended. When keep=true, the last-used index is incremented for the new images. If this is acceptable, I will open a draft PR.

@kswang1029
Copy link
Contributor

I just pushed a branch for an initial implementation, where the index is incremented each time keep=true for all generated moment images, but this can be changed.

So in my previous example (assuming I got the names right for the moment numbers!) you would get:

  • mom -1 keep=false: image.average
  • mom 0 keep=true: image.integrated1
  • mom -1, 0, 1 keep=true: image.average2, image.integrated2 , image.weighted_coord2

When keep=false, there is no index appended. When keep=true, the last-used index is incremented for the new images. If this is acceptable, I will open a draft PR.

Yes this sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request requiring frontend this backend issue requires work in both frontend and backend
Projects
None yet
Development

No branches or pull requests

2 participants