Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove imageanalysis parser for CRTF imports #1219

Closed
pford opened this issue Nov 22, 2022 · 0 comments · Fixed by #1220
Closed

Remove imageanalysis parser for CRTF imports #1219

pford opened this issue Nov 22, 2022 · 0 comments · Fixed by #1220
Assignees
Labels
casa Issue due to casacore implementation performance
Milestone

Comments

@pford
Copy link
Collaborator

pford commented Nov 22, 2022

Due to performance and incompatibility issues, remove use of casa imageanalysis CRTF import implementation and use CARTA implementation only. This will improve the CRTF performance issue noted in #1216 .

With the addition of annotation regions in CARTA in v4.0, some regions which are not supported in CRTF (compass and ruler) are exported with a preceding # so that the CRTF file remains supported by other packages such as casaviewer, astropy, etc. The # usually indicates a comment line and is skipped by the casa CRTF parser. Since these lines must be checked in CARTA for an annotation region definition, we can no longer use imageanalysis to import CRTF files since there will be no indication that these regions were skipped.

The imagenanalysis implementation has slower performance because, as part of the import to create casa annotation regions, (1) pixel coordinates are converted to world coordinates (direction coordinate only, else fails) and (2) a composite region of all regions in the file is created. However, these features are not required or used by CARTA. In addition, any import failure in the file causes the entire import to fail, which was one motivation for the CARTA parser implementation as a workaround.

For now, imagenalysis continues to be used for CRTF region export for formatting, particularly world coordinate strings.

@pford pford added performance casa Issue due to casacore implementation labels Nov 22, 2022
@pford pford added this to the v4.0-b1 milestone Nov 22, 2022
@pford pford self-assigned this Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
casa Issue due to casacore implementation performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant