Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[animator] channel animation playback hangs at the last channel when computed polarization component is selected #1238

Closed
kswang1029 opened this issue Nov 23, 2022 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kswang1029
Copy link
Contributor

kswang1029 commented Nov 23, 2022

Describe the bug
When we load a Stokes cube, we can have infinite loop of channel playback for a give Stokes component. However, if a computed polarization component is selected, such as Plinear, the channel playback hangs at the last channel.

To Reproduce
Steps to reproduce the behavior:

  1. load a Stokes cube
  2. select Stoke Q and trigger channel animation playback. When the last channel is rendered, the next would be the first channel.
  3. switch to Plinear or other computed component and select a channel close to the last channel (just to save time for observing)
  4. trigger channel animation playback and it will hang at the last channel

Expected behavior
channel animation playback for computed polarization component should behave just like regular Stokes.

Screenshots or videos

Screen.Recording.2022-11-23.at.13.42.25.mov

Platform info (please complete the following information):

  • OS [e.g. macOS Monterey]: macOS Monterey
  • Browser [e.g. chrome, safari, electron app]: v3-stable electron app
  • Browser version [e.g. 22]:
  • Backend branch [e.g. dev, v3b2 release]: v3-stable
  • Frontend branch [e.g. dev, v3b2 release]: v3-stable
@kswang1029 kswang1029 added the bug Something isn't working label Nov 23, 2022
@kswang1029 kswang1029 assigned kswang1029 and crocka and unassigned kswang1029 Jan 31, 2023
@kswang1029 kswang1029 added this to the v4.0-b1 milestone Jan 31, 2023
@kswang1029 kswang1029 assigned markccchiang and unassigned crocka Feb 6, 2023
@kswang1029 kswang1029 transferred this issue from CARTAvis/carta-frontend Feb 6, 2023
@kswang1029
Copy link
Contributor Author

Thanks to @crocka for diagnosing this issue. This seems a backend one.

@markccchiang
Copy link
Contributor

Actually, I think this problem is from the incorrect stokes index setting in the StartAnimation's sub-messages AnimationFrame, which is sent by the frontend. I will fix it on the frontend side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants