Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style improvements in HTTP server code #1260

Closed
confluence opened this issue May 2, 2023 · 0 comments · Fixed by #1324
Closed

Code style improvements in HTTP server code #1260

confluence opened this issue May 2, 2023 · 0 comments · Fixed by #1324
Assignees
@markccchiang
Labels
code maintenance For issues relating to code maintenance and quality
Milestone
v5.0-beta

Comments

@confluence
Copy link
Collaborator

confluence commented May 2, 2023 •
edited
Loading

As discussed in this comment and this comment, the object types passed as function parameters should be enum values rather than string literals, and schema URLs should be looked up in an unordered map with object types as keys.
@kswang1029 kswang1029 added the code maintenance For issues relating to code maintenance and quality label May 9, 2023
@kswang1029 kswang1029 added this to the v5.0-beta milestone Oct 3, 2023
@markccchiang markccchiang mentioned this issue Oct 25, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markccchiang markccchiang

Labels
code maintenance For issues relating to code maintenance and quality
Projects
None yet
Milestone
v5.0-beta
Development

Successfully merging a pull request may close this issue.

Improve the code style in HTTP server CARTAvis/carta-backend
3 participants
@confluence @markccchiang @kswang1029