Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] rendered image does not have mask as defined via LEL #1291

Closed
kswang1029 opened this issue Aug 7, 2023 · 0 comments · Fixed by #1292
Closed

[question] rendered image does not have mask as defined via LEL #1291

kswang1029 opened this issue Aug 7, 2023 · 0 comments · Fixed by #1292
Assignees
Labels
bug Something isn't working question Further information is requested
Milestone

Comments

@kswang1029
Copy link
Contributor

Describe the bug
This is an issue from CARTAvis/carta-frontend#2220 and investigated by @crocka . If the frontend sends the LEL expression “dice_one.fits”[“dice_one.fits”>2], a mask will be generated and applied but the rendered image appears not having the mask. The region statistics, however, does consider the mask.

To Reproduce
Steps to reproduce the behavior:

  1. need a modified frontend to disable incorrect parsing of [ ] in LEL expression
  2. load an image with LEL like “dice_one.fits”[“dice_one.fits”>2] (see frontend issue Image arithmetic does not seem to work carta-frontend#2220)
  3. the rendered image should have a mask but it does not

Expected behavior
The rendered image should have a mask (as NaN)

Platform info (please complete the following information):

  • OS [e.g. macOS Monterey]: macOS Ventura
  • Browser [e.g. chrome, safari, electron app]: chrome
  • Browser version [e.g. 22]: 104
  • Backend branch [e.g. dev, v3b2 release]: dev
  • Frontend branch [e.g. dev, v3b2 release]: dev
@kswang1029 kswang1029 added bug Something isn't working question Further information is requested labels Aug 7, 2023
@kswang1029 kswang1029 added this to the v4.0-stable milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants