Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom histogram calculations #829

Closed
kswang1029 opened this issue Jun 9, 2021 · 4 comments
Closed

custom histogram calculations #829

kswang1029 opened this issue Jun 9, 2021 · 4 comments
Assignees
@markccchiang
Labels
enhancement New feature or request requiring frontend this backend issue requires work in both frontend and backend

Comments

@kswang1029
Copy link
Contributor

At the moment a histogram is computed with range and n_bin derived automatically. To make the histogram widget be more useful for analysis, custom

  • n_bin
  • bin_width
  • range
    need to be configurable.

related to frontend: CARTAvis/carta-frontend#1488
@kswang1029 kswang1029 added the enhancement New feature or request label Jun 9, 2021
@kswang1029 kswang1029 mentioned this issue Jun 9, 2021
Closed
@kswang1029 kswang1029 added the requiring frontend this backend issue requires work in both frontend and backend label Jun 9, 2021
@veggiesaurus
Copy link
Collaborator

veggiesaurus commented Jun 9, 2021 •
edited
Loading

I think this might already actually be supported on the backend

edit: no, currently the histogram config only supports num_bins, not the range itself

@kswang1029
Copy link
Contributor Author

and need ICD changes I suppose

@veggiesaurus
Copy link
Collaborator

and need ICD changes I suppose

yes, non-breaking ones though, and probably pretty trivial

@kswang1029 kswang1029 added this to the v3.0b-3 milestone Jan 9, 2022
@kswang1029 kswang1029 removed this from the v3.0b-3 milestone Jun 6, 2022
@markccchiang markccchiang self-assigned this Dec 15, 2022
@markccchiang markccchiang mentioned this issue Apr 14, 2023
Merged
5 tasks
@kswang1029
Copy link
Contributor Author

Done with #1254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markccchiang markccchiang

Labels
enhancement New feature or request requiring frontend this backend issue requires work in both frontend and backend
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

jolopezl/829-custom-histogram-calculations CARTAvis/carta-backend
4 participants
@veggiesaurus @jolopezl @markccchiang @kswang1029