Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues with contour animation when contour compression is disabled #848

Closed
veggiesaurus opened this issue Jun 18, 2021 · 1 comment · Fixed by #852
Closed

fix issues with contour animation when contour compression is disabled #848

veggiesaurus opened this issue Jun 18, 2021 · 1 comment · Fixed by #852
Assignees
Labels
bug Something isn't working
Milestone

Comments

@veggiesaurus
Copy link
Collaborator

As discovered by @kswang1029, playing back an animation with contours at a high frame rate can result in garbled ICD messages when using the MacOS electron app. @ajm-asiaa worked out that this only occurs with the electron app (and not the homebrew install) because contour compression is disabled.

This may be because we're instructing uWebSockets to compress the uncompressed contour messages using deflate. Perhaps the buffer size is too small 🤔

@veggiesaurus veggiesaurus added the backport for issues that require backporting to an existing release label Jun 18, 2021
@veggiesaurus
Copy link
Collaborator Author

veggiesaurus commented Jun 18, 2021

now that I know what I'm looking for, I can reproduce this error on Ubuntu 20.04 in the dev branch as well. It seems to happen more frequently when the dev console is open (because network data is inspected, leading to reduced throughput of data)

2021-06-18.16-17-41.mp4

@veggiesaurus veggiesaurus added bug Something isn't working and removed backport for issues that require backporting to an existing release labels Jun 22, 2021
@veggiesaurus veggiesaurus added this to the v3.0b-1 milestone Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants