Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve speed of HDF5 header parsing #861

Closed
veggiesaurus opened this issue Jun 30, 2021 · 1 comment · Fixed by #864
Closed

Improve speed of HDF5 header parsing #861

veggiesaurus opened this issue Jun 30, 2021 · 1 comment · Fixed by #864
Assignees
@confluence
Labels
enhancement New feature or request
Milestone
v3.0b-1

Comments

@veggiesaurus
Copy link
Collaborator

The FITS file hlsp_candels_hst_acs_gn-tot-60mas_f606w_v1.0_drz.fits has roughly 13000 header entries. The file info takes ~2 seconds to load. After converting to HDF5, it takes about 30 seconds to load the file info in CARTA.

I don't think this is an inherent limitation of the HDF5 file format though, because viewing the attributes in HDF Compass takes about 2 seconds as well. We should be able to get the HDF5 load time down to ~4 seconds as a maximum in CARTA.
@veggiesaurus veggiesaurus added the enhancement New feature or request label Jun 30, 2021
@veggiesaurus veggiesaurus added this to the v3.0b-1 milestone Jun 30, 2021
@veggiesaurus
Copy link
Collaborator Author

changing to estimate of 1, as it should be as simple as switching to using H5Aiterate2 instead of manually opening each attribute using H5Aopen_idx

@confluence confluence mentioned this issue Jul 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@confluence confluence

Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.0b-1
2 participants
@veggiesaurus @confluence