Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect projection in v3b1 when CROTA keys present #912

Closed
Jordatious opened this issue Sep 2, 2021 · 4 comments · Fixed by #937
Closed

Incorrect projection in v3b1 when CROTA keys present #912

Jordatious opened this issue Sep 2, 2021 · 4 comments · Fixed by #937
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Jordatious
Copy link

An IDIA user has some mosaics created from CASA and WSClean images, which both include the deprecated CROTA FITS header keys. I've asked for a copy of these images to provide for @kswang1029.

carta.idia (v2.0.1) projects it fine, including with diagonal grid lines for the mosaic of the WSClean images. But carta-beta.idia (v3.0.0-beta.1b) incorrectly projects it without the diagonal grid lines. Spatially matching them doesn’t change it either.

@veggiesaurus
Copy link
Collaborator

example_images.zip

Here's an example of two images (C.fits and C_rot.fits). They are identical apart from the CROTA2 term. Both display correctly in DS9 and CARTA 2.0, but CARTA 3.0 beta-1 does not replace the CROTA2 entry with a CD matrix, and it does not seem to display correctly

@veggiesaurus
Copy link
Collaborator

veggiesaurus commented Sep 2, 2021

Strangely enough, the CARTA backend now seems to replace CROTA2 with CROTA 🤷 not sure why.

I noticed that converting the file to HDF5 using fits2idia solves the issue (CROTA2 is no longer replaced with CROTA and the overlay renders correctly):

image

@kswang1029
Copy link
Contributor

Strangely enough, the CARTA backend now seems to replace CROTA2 with CROTA 🤷 not sure why.

I noticed that converting the file to HDF5 using fits2idia solves the issue (CROTA2 is no longer replaced with CROTA and the overlay renders correctly):

image

Hmm so it is actually a backend issue?🤔

@veggiesaurus
Copy link
Collaborator

Hmm so it is actually a backend issue?

Looks like a casacore issue 🤔 Moving to carta-backend and assigning @pford

@veggiesaurus veggiesaurus transferred this issue from CARTAvis/carta-frontend Sep 2, 2021
@veggiesaurus veggiesaurus added this to the v3.0b-2 milestone Sep 2, 2021
@veggiesaurus veggiesaurus added the bug Something isn't working label Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants