Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region export permission #1133

Closed
kswang1029 opened this issue Jun 21, 2022 · 1 comment · Fixed by #1154
Closed

region export permission #1133

kswang1029 opened this issue Jun 21, 2022 · 1 comment · Fixed by #1154
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kswang1029
Copy link
Contributor

kswang1029 commented Jun 21, 2022

Describe the bug
This is reported by a user via email.

I think when saving crtf regions, if you don't have write permission,
carta still gives you the green popup that says it has saved the crtf
regions for file xxx, but doesn't save anything. It should probably
not claim to have saved the region in this case.

[test: make a crtf file, make it non-writeable, then try to save a
region from carta to this file - it will first ask you whether you
want to overwrite the file, you say yes, then you get the green popup
suggesting it has saved, but in fact it has not]

To Reproduce
Steps to reproduce the behavior:

[test: make a crtf file, make it non-writeable, then try to save a
region from carta to this file - it will first ask you whether you
want to overwrite the file, you say yes, then you get the green popup
suggesting it has saved, but in fact it has not]

Expected behavior
If there is no permission to save a region file, the returned message should be a failure.

Platform info (please complete the following information):
the user did not provide platform info

  • OS [e.g. macOS Monterey]:
  • Browser [e.g. chrome, safari, electron app]:
  • Browser version [e.g. 22]:
  • Backend branch [e.g. dev, v3b2 release]:
  • Frontend branch [e.g. dev, v3b2 release]:
@kswang1029 kswang1029 added the bug Something isn't working label Jun 21, 2022
@veggiesaurus veggiesaurus added this to the v3.0-stable milestone Jul 20, 2022
@veggiesaurus
Copy link
Collaborator

@pford can you handle this for the stable release? It should be relatively easy to fix, I imagine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants