Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file id of moment images #1224

Closed
kswang1029 opened this issue Oct 8, 2020 · 2 comments
Closed

file id of moment images #1224

kswang1029 opened this issue Oct 8, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@kswang1029
Copy link
Collaborator

kswang1029 commented Oct 8, 2020

(Not sure if this is frontend or backend issue)
To reproduce the issue:

  1. load set_HD163296/HD163296_CO_2_1.fits
  2. create a rectangle region at the center and make moment images
  3. match the resulting moment images to the spatial reference (aka HD163296_CO_2_1.fits)
  4. regenerate moment images from HD163296_CO_2_1.fits and we will see
    Screen Shot 2020-10-08 at 10 41 26 AM

When we re-request a new set of moment calculations, how the file_id of the previous moment image is handled? Do we need "CLOSE_IMAGE" involved?

@kswang1029 kswang1029 added the bug Something isn't working label Oct 20, 2020
@markccchiang
Copy link
Contributor

@kswang1029 The file_id of the previous moment image will be closed, i.e. via the CLOSE_IMAGE command. Does this error messages still appear in the backend branch mark/refactor_moment_generator?

@kswang1029
Copy link
Collaborator Author

@markccchiang Tested with mark/refactor_moment_generator, it works well without those error messages. Close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants