Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend crash when loading a 1x1 pixel image #1365

Closed
kswang1029 opened this issue Mar 25, 2021 · 5 comments · Fixed by #1611
Closed

frontend crash when loading a 1x1 pixel image #1365

kswang1029 opened this issue Mar 25, 2021 · 5 comments · Fixed by #1611
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kswang1029
Copy link
Collaborator

kswang1029 commented Mar 25, 2021

This should be considered as an edge case but might accidentally happen when users generate a 1x1 subimage via the CARTA GUI. This only happens with 1x1 image. With 1xn it works fine.
Screen Shot 2021-03-25 at 11 22 11 AM

@kswang1029 kswang1029 added the bug Something isn't working label Mar 25, 2021
@veggiesaurus
Copy link
Collaborator

I think it's a corner case instead of an edge case 😇

@kswang1029
Copy link
Collaborator Author

I think it's a corner case instead of an edge case 😇

LOL

@veggiesaurus
Copy link
Collaborator

remind me again, did we resolve to serve any tile smaller than 4x4 as uncompressed?

@kswang1029
Copy link
Collaborator Author

remind me again, did we resolve to serve any tile smaller than 4x4 as uncompressed?

not sure🤔 I seem not having that memory. Test images are attached.
tmp.zip

@Kechil Kechil added this to the v3.0b-1 milestone Jun 23, 2021
@TienHao
Copy link
Contributor

TienHao commented Aug 10, 2021

I find out that 1x2, 1x3 and 2x1 images also have this problem.
The tiles in RasterTileData messages contains more elements in imageData than asyncDecompressTile() expects. [width x height x 4]
They all have at least four 0 in the end.

1x1 -> imageData length = 8 (expect 4)
1*1

1x2 -> imageData length = 16 (expect 8)
1*2

1x3 -> imageData length = 16 (expect 12)
1*3

2x1 -> imageData length = 16 (expect 8)
2*1

2x2 -> imageData length =16 👍
2*2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants