Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to render older AIPS cubes with FELO-HEL velocity axis #1771

Closed
jehibbard opened this issue Feb 4, 2022 · 1 comment
Closed

Ability to render older AIPS cubes with FELO-HEL velocity axis #1771

jehibbard opened this issue Feb 4, 2022 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jehibbard
Copy link

Describe the bug
v2.0 correctly renders older cubes that have CTYPE3 units of FELO-HEL or VELO-LSR, but v3.0-2b does not.

To Reproduce
Steps to reproduce the behavior:

  1. Get the two cubes from https://www.cv.nrao.edu/~jhibbard/FITS/u10214/ (one is VLA data reduced in AIPS, the other from CARMA reduced in Miriad
  2. Read them into both CARTA v2.0 and v3.0-2b
  3. Set up contours for each cube (levels don't matter)
  4. You'll see the following:
  • the velocity units in v3b are not km/s, and frequency is not reported
  • the contours from one cube overlay on different channels in the other (v2.0 is correct)
  • the zprofile spectra look the same, but using the red bar to change the channel works very differently in the two versions (e.g. whether or it changes the channel that is displayed/contoured depends on which image is selected, and whether or not you are in the region where the spectra overlap or not)
  • in the image widget grear wheel, the restfreq does not show up even though this field is filled in the image headers

Expected behavior
I expect v3b to give same results as v2.0

Screenshots or videos
See text in attached screenshot
CARTA-FELO-HEL-issue

Platform info (please complete the following information):

  • OS: [e.g. iOS] macOS Catalina 10.15.7
  • Browser [e.g. chrome, safari] Safari 15.3
  • Version [e.g. 22] v2.0 & 3.0-2b

Additional context
Here is what Kuo-Song had to say about this problem:

"This is because before v2.0 (inclusive), RAW FITS headers are pre-processed by casacore to have a unified format (happen at the backend) for the frontend to render coordinate grid and perform image matching. After v2.0, due to users’ complaints about not seeing RAW headers or casacore not processing headers correctly, we (actually Pam did :) ) removed the casacore preprocessor and just use CFITSIO to get the RAW header. So in this case, yes, I think this is because the frontend library we used for coordinate grid and image matching (AST) may not interpret or handle FELO-HEL well. Could you submit an issue to the frontend repo? We will try to investigate this backward compatibility issue. Thanks."

@kswang1029 kswang1029 added the bug Something isn't working label Mar 17, 2022
@pford pford self-assigned this Sep 2, 2022
@pford
Copy link
Collaborator

pford commented Sep 2, 2022

Backend PR merged, to restore previous behavior using casacore FITS headers when this velocity axis is detected.

@kswang1029 please close this issue when appropriate.

@pford pford added this to the v4.0-b1 milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants