Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing regions when the image is unmatched to the reference and gets a copy of the reference region list #1780

Closed
kswang1029 opened this issue Dec 8, 2021 · 5 comments · Fixed by #1912
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kswang1029
Copy link
Collaborator

To reproduce:

  1. load an image and a region file with 2000 regions
  2. append the same image and match it to the reference image
  3. keep the region list widget active in the view
  4. unmatch the 2nd image and it will get a copy (slow~) of the region list from the 1st image. We will see lots of SET_REGION_ACK but the total count in the region list is incorrect. In this case we expect to see 2000 region registered but there are 1813 only.
@kswang1029 kswang1029 transferred this issue from CARTAvis/carta-frontend Dec 9, 2021
@kswang1029 kswang1029 added the bug Something isn't working label Jan 5, 2022
@kswang1029 kswang1029 assigned pford and markccchiang and unassigned pford Jan 5, 2022
@markccchiang
Copy link
Contributor

@kswang1029 are there sample image and region files that I can use to do the test?

@markccchiang
Copy link
Contributor

It looks like the frontend's problem. When unmatching the image, the frontend only sends less than 2000 (say 1813) SET_REGION commands to the backend.

@kswang1029 kswang1029 transferred this issue from CARTAvis/carta-backend Feb 14, 2022
@kswang1029
Copy link
Collaborator Author

It looks like the frontend's problem. When unmatching the image, the frontend only sends less than 2000 (say 1813) SET_REGION commands to the backend.

@markccchiang are we able to tell it is the first part or the last part or random parts of the region list missing?

@veggiesaurus
Copy link
Collaborator

I suggest we add a new ICD entry for migrating regions. Perhaps SET_MULTIPLE_REGIONS? So instead of doing this 2000 times, we just send a single message

@markccchiang
Copy link
Contributor

I suggest we add a new ICD entry for migrating regions. Perhaps SET_MULTIPLE_REGIONS? So instead of doing this 2000 times, we just send a single message

I think it is a much more efficient way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants