Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from point sprites to manually drawn rectangles for catalogue rendering #1802

Closed
veggiesaurus opened this issue Mar 7, 2022 — with Slack · 1 comment · Fixed by #2017
Closed

Migrate from point sprites to manually drawn rectangles for catalogue rendering #1802

veggiesaurus opened this issue Mar 7, 2022 — with Slack · 1 comment · Fixed by #2017
Assignees
@YuHsuan-Hwang
Labels
enhancement New feature or request

Comments

@veggiesaurus Slack
Copy link
Collaborator

We need to move from using GL.POINTS to draw aliased points when rendering the catalogue overlay. This has some severe limiations, as the maximum point size is heavily browser and GPU dependent. Instead, we should use a vertex-pulling approach to draw two triangles per data point.
@veggiesaurus veggiesaurus added the enhancement New feature or request label Mar 7, 2022 — with Slack
@veggiesaurus veggiesaurus mentioned this issue Mar 7, 2022
Closed
@veggiesaurus
Copy link
Collaborator Author

@Jordatious this is the issue I just mentioned. Hopefully 4.0-beta1.

@YuHsuan-Hwang YuHsuan-Hwang mentioned this issue Sep 23, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YuHsuan-Hwang YuHsuan-Hwang

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Yuhsuan/1802 catalog overlay refactor CARTAvis/carta-frontend
2 participants
@veggiesaurus @YuHsuan-Hwang