Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra catalog overlay sources at the origin #1823

Closed
YuHsuan-Hwang opened this issue Apr 11, 2022 · 0 comments · Fixed by #1825
Closed

Extra catalog overlay sources at the origin #1823

YuHsuan-Hwang opened this issue Apr 11, 2022 · 0 comments · Fixed by #1825
Assignees
@YuHsuan-Hwang
Labels
bug Something isn't working

Comments

@YuHsuan-Hwang
Copy link
Collaborator

Describe the bug
The catalog image overlay is rendering extra sources at the origin. May need to adjust the count parameter when calling gl.drawArrays(mode, first, count).

To Reproduce
Steps to reproduce the behavior:

  1. Open a catalog and an image
  2. Plot all the sources on the image
  3. Click Reset. See extra circles at the origin.

or

  1. Filter the sources. See extra circles at the origin.
  2. Plot the filtered sources. Extra circles still exist.

Expected behavior
no extra sources at the origin

Screenshots or videos
image

Platform info (please complete the following information):

  • OS: macOS
  • Browser: chrome
  • Version: after 3.0-2b
@YuHsuan-Hwang YuHsuan-Hwang added the bug Something isn't working label Apr 11, 2022
@YuHsuan-Hwang YuHsuan-Hwang self-assigned this Apr 11, 2022
@YuHsuan-Hwang YuHsuan-Hwang mentioned this issue Apr 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YuHsuan-Hwang YuHsuan-Hwang

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Yuhsuan/1823 catalog overlay count CARTAvis/carta-frontend
1 participant
@YuHsuan-Hwang