-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide an optional second spectral conversion to the cursor info in the spectral profiler #1837
Comments
@jrhosk @YuHsuan-Hwang This is one of the possible (and easiest maybe) solutions for #1703 that I can think of. As for the actual implementation of adding a 2nd spectral axis as PR #1835 is doing, there might be another way to achieve similar result by treating x2 and y2 axis as independent axes (based on my understanding from chartjs doc) but this requires R&D time to verify the idea. For the upcoming v3 release, I suggest we try to achieve the cursor info approach and worry about #1703 later on. Please let me know if this is sensible to you. :) |
The document is great, thank you! Are there other such documents? More documentation would be amazing. |
@jrhosk we should evaluate these two features with @YuHsuan-Hwang and see which one is realistic for v3 final release. |
I would prefer we work on this issue for v3 |
How about this feature goes first and if time allows, revisit #1703 and continue #1835?. The two features have common parts (spectral conversion, specifically) so part of codes in #1835 may be re-used I guess. |
given the time pressure of the v3 release, an alternative solution for the feature #1703 (see implementation challenges in #1835) is to just add an additional spectral value based on the user selection to the cursor info in the spectral profiler.
In the above example, at the moment we show (frequency, intensity). If it is enabled from the settings dialog (default off) and velocity is selected, then we show (frequency, velocity, intensity) instead.
The reference image for freq-velo conversion should be the “active” or user-selected image. This is relevant when multi-profile plot mode is enabled.
quick mockup
Attached is a doc I compiled from AST user manual regarding spectral and spatial conversion functions. Hope it helps.
carta_ast_specConvert_wcConvert.pdf
The text was updated successfully, but these errors were encountered: