Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect image statistics after a region is deleted where there are multiple statistics widget configured explicitly to display image region statistics #1855

Closed
kswang1029 opened this issue May 17, 2022 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kswang1029
Copy link
Collaborator

kswang1029 commented May 17, 2022

Describe the bug
When there are two statistics widgets configured explicitly to display image region statistics, for example, one for image01 and region1 and the other for image02 and region1. Region1 is the only region created in CARTA. If we delete region1, the statistics widget for image01 shows the correct full image statistics as expected. But the other widget for image02 displays incorrect statistics. Based on the ICD message flow, it seems the frontend does not set the requirement properly in this case. Please refer to the video as a demo of the issue.

UPDATE: after few more tests, histogram widget has the same issue. Spatial profiler has the issue. Spectral profiler does not have the issue.

To Reproduce
Steps to reproduce the behavior:

  1. download the test images at https://drive.google.com/file/d/1uv2f-quEVsf1r9Imt_SwNS6EFv1NvHmO/view?usp=sharing
  2. load image01.fits and image02.fits and match them spatially
  3. load the region file polygon.crtf
  4. load two statistics widget
  5. configure one to show image01.fits and the region explicitly and configure the other one to show image02.fits and the region explicitly too
  6. delete the region
  7. the NumPixel count should be ~10^8 but one of the widget did not update correctly and still shows the region stat.

Expected behavior
statistics requirement is set correctly after a region is deleted so that the two statistics can display correct full image statistics for image01 and image02 respectively.

Screenshots or videos

Screen.Recording.2022-05-17.at.12.35.15.mov

Platform info (please complete the following information):

  • OS [e.g. macOS Monterey]: macOS Monterey
  • Browser [e.g. chrome, safari, electron app]: electron app
  • Browser version [e.g. 22]:
  • Backend branch [e.g. dev, v3b2 release]: v3b3
  • Frontend branch [e.g. dev, v3b2 release]: v3b3
@YuHsuan-Hwang
Copy link
Collaborator

fixed via #1869

@veggiesaurus veggiesaurus added this to the v3.0-stable milestone Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants