Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing PV preview viewer if it is closed when docked #2249

Closed
kswang1029 opened this issue Sep 10, 2023 · 1 comment
Closed

Missing PV preview viewer if it is closed when docked #2249

kswang1029 opened this issue Sep 10, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kswang1029
Copy link
Collaborator

Describe the bug
When we request PV preview, the PV preview viewer will show up as a floating widget. If we dock it and close it, then click "Start preview" button, the PV preview viewer never comes back. If the PV preview viewer stays floating and being closed, things are just fine.

To Reproduce
Steps to reproduce the behavior:

  1. load a cube and request pv preview.
  2. dock the PV preview widget
  3. close the PV preview widget
  4. click "Start preview" button. We expect to see the PV preview widget shows up but it does not.

Expected behavior
In this use case, the PV preview widget should come back.

Platform info (please complete the following information):

  • OS [e.g. macOS Monterey]: macOS Ventura
  • Browser [e.g. chrome, safari, electron app]: electron
  • Browser version [e.g. 22]:
  • Backend branch [e.g. dev, v3b2 release]: dev. v4-stable
  • Frontend branch [e.g. dev, v3b2 release]: dev. v4-stable
@kswang1029 kswang1029 added the bug Something isn't working label Sep 10, 2023
@kswang1029 kswang1029 changed the title Missing PV preview viewer if it is docked and closed Missing PV preview viewer if it is closed when docked Sep 11, 2023
@kswang1029 kswang1029 added this to the v5.0-beta milestone Oct 3, 2023
@kswang1029
Copy link
Collaborator Author

fixed via PR#2257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants