Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to provide entire path in 'load file' widget #609

Closed
jott3077 opened this issue Nov 25, 2019 · 3 comments
Closed

ability to provide entire path in 'load file' widget #609

jott3077 opened this issue Nov 25, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@jott3077
Copy link

in the 'file loading widget one can only browse through the file system. Frequently it is more convenient to copy and paste in the path directly, as it saves many clicks.
Need to make sure though that this does not open a security hole.

@veggiesaurus veggiesaurus transferred this issue from CARTAvis/carta-backend Nov 26, 2019
@veggiesaurus
Copy link
Collaborator

This shouldn't be too difficult, considering that we have the ability to browse a specific folder by entering a folder parameter as a URL query. I don't think there are any security risks, as this will all be checked by the backend in any case.

My suggestion would be to put a small "edit" icon after the folder breadcrumbs, which replaces the breadcrumbs with a text input when the user clicks it.
image

Pressing "enter" on the input would browse to the specified folder, and pressing "escape" would reset. Both enter and escape actions would show the breadcrumbs again. Something along these lines:
path_entry

My feeling is that this should be undertaken at the same time as #606

@jott3077
Copy link
Author

That looks like a great way to do it!

@kswang1029
Copy link
Collaborator

Done with #2134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants