Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edge pixels artifacts on the right side #666

Closed
kswang1029 opened this issue Jan 8, 2020 · 5 comments · Fixed by #1529
Closed

edge pixels artifacts on the right side #666

kswang1029 opened this issue Jan 8, 2020 · 5 comments · Fixed by #1529
Assignees
@veggiesaurus
Labels
bug Something isn't working question Further information is requested
Milestone
v3.0b-1

Comments

@kswang1029
Copy link
Collaborator

kswang1029 commented Jan 8, 2020 •
edited

could this due to #623 ?
IRAS_17150-3224_sci spw27 cube I manual image pbcor fits-image-2020-1-8-16-53-22

The requested tiles (original image is 2800 pixel x 2800 pixel) are
Screen Shot 2020-01-08 at 16 50 38

Also a question: why it requested 9 tiles (0,0) to (2,2), instead of 16 tiles from (0,0) to (3,3)?
@kswang1029 kswang1029 added bug Something isn't working question Further information is requested labels Jan 8, 2020
@kswang1029
Copy link
Collaborator Author

weirdly I cannot reproduce it anymore...... Close for now and I will keep this in mind.

@kswang1029 kswang1029 reopened this Jan 8, 2020
@kswang1029
Copy link
Collaborator Author

OK, it shows up when javascript console is enabled.... even more weird....

@kswang1029
Copy link
Collaborator Author

kswang1029 commented Jun 5, 2020 •
edited

It shows up and this time no js console is enabled!!!
I suspect it is there for a while but with the default NaN color it is harder to see.

Attached (generated with "export as png" button) is the case with transparent NaN.

M83 LSB_L pbcor fits-image-2020-6-5-10-37-50

with different zoom levels, the artifacts change.
Jun-05-2020 10-44-21

@kswang1029
Copy link
Collaborator Author

More examples:

Right edge:
Screen Shot 2020-06-18 at 10 57 52 AM

Top edge:
Screen Shot 2020-06-18 at 10 57 01 AM

@veggiesaurus veggiesaurus self-assigned this Aug 24, 2020
@veggiesaurus
Copy link
Collaborator

@kswang1029 this was bugging me, so I tried to fix it. Can you see if angus/666_edge_pixels solves the problem?

@veggiesaurus veggiesaurus added this to the v3.0b-1 milestone Jun 26, 2021
@veggiesaurus veggiesaurus mentioned this issue Jun 26, 2021
Merged
@veggiesaurus veggiesaurus mentioned this issue Aug 30, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veggiesaurus veggiesaurus

Labels
bug Something isn't working question Further information is requested
Projects
None yet
Milestone
v3.0b-1
Development

Successfully merging a pull request may close this issue.

Angus/666 edge pixels CARTAvis/carta-frontend
2 participants
@veggiesaurus @kswang1029